Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
F17930049: D17653.id.diff
Wed, Jul 30, 5:31 PM
F17913451: D17653.diff
Tue, Jul 29, 5:52 PM
Unknown Object (File)
Jun 27 2025, 10:34 PM
Unknown Object (File)
Jun 27 2025, 10:37 AM
Unknown Object (File)
May 24 2025, 8:45 PM
Unknown Object (File)
May 11 2025, 5:00 PM
Unknown Object (File)
May 5 2025, 8:00 PM
Unknown Object (File)
Apr 30 2025, 4:12 AM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable