Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 12:22 PM
Unknown Object (File)
Sun, Nov 24, 3:18 PM
Unknown Object (File)
Sat, Nov 23, 4:44 AM
Unknown Object (File)
Sat, Nov 23, 12:31 AM
Unknown Object (File)
Wed, Nov 20, 12:51 AM
Unknown Object (File)
Sat, Nov 16, 5:57 AM
Unknown Object (File)
Tue, Nov 12, 2:42 PM
Unknown Object (File)
Sat, Nov 9, 1:21 PM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable