When requesting file data, make "Range: bytes=0-" work correctly
ClosedPublic
Actions

Authored by epriestley on Apr 5 2017, 6:34 PM.

Details

Reviewers

chad

Maniphest Tasks

T12219: Some MP4 videos do not play in Chrome

Commits

rPf2a26b260100: When requesting file data, make "Range: bytes=0-" work correctly

Summary

Ref T12219. Chrome can send requests with a "Range: bytes=0-" header, which just means "the whole file", but we don't respond correctly because of a null vs 0 issue.

Test Plan

Sent a raw bytes=0- request, saw a proper resonse.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 5 2017, 6:34 PM

chad accepted this revision.Apr 5 2017, 6:34 PM

This revision is now accepted and ready to land.Apr 5 2017, 6:34 PM

Harbormaster completed remote builds in B16325: Diff 42396.Apr 5 2017, 6:35 PM

Closed by commit rPf2a26b260100: When requesting file data, make "Range: bytes=0-" work correctly (authored by epriestley, committed by epriestley). · Explain WhyApr 5 2017, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

AphrontFileResponse.php

2 lines

Diff 42397

View Options

src/aphront/response/AphrontFileResponse.php

When requesting file data, make "Range: bytes=0-" work correctlyClosedPublicActions