Page MenuHomePhabricator
Differential D17627

When requesting file data, make "Range: bytes=0-" work correctly
ClosedPublic
Actions

Authored by epriestley on Apr 5 2017, 6:34 PM.
Tags
None
Referenced Files
F15531049: D17627.id42397.diff
Wed, Apr 23, 9:22 AM
F15524966: D17627.diff
Mon, Apr 21, 11:30 AM
F15515886: D17627.id.diff
Fri, Apr 18, 2:07 PM
F15512452: D17627.diff
Thu, Apr 17, 10:54 AM
F15464303: D17627.id42397.diff
Wed, Apr 2, 8:17 AM
F15464300: D17627.id42396.diff
Wed, Apr 2, 8:17 AM
F15462448: D17627.diff
Tue, Apr 1, 3:11 PM
F15420086: D17627.id42396.diff
Mar 21 2025, 11:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12219: Some MP4 videos do not play in Chrome
Commits
rPf2a26b260100: When requesting file data, make "Range: bytes=0-" work correctly
Summary

Ref T12219. Chrome can send requests with a "Range: bytes=0-" header, which just means "the whole file", but we don't respond correctly because of a null vs 0 issue.

Test Plan

Sent a raw bytes=0- request, saw a proper resonse.

Diff Detail

Repository
rP Phabricator
Branch
files17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16325
Build 21705: Run Core Tests
Build 21704: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 5 2017, 6:34 PM
chad accepted this revision.Apr 5 2017, 6:34 PM
This revision is now accepted and ready to land.Apr 5 2017, 6:34 PM
Harbormaster completed remote builds in B16325: Diff 42396.Apr 5 2017, 6:35 PM
Closed by commit rPf2a26b260100: When requesting file data, make "Range: bytes=0-" work correctly (authored by epriestley, committed by epriestley). · Explain WhyApr 5 2017, 6:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
response/
2 lines

Diff 42396

View Options

src/aphront/response/AphrontFileResponse.php

Loading...
Phabricator · Built by Phacility