Differential D17605

Don't downgrade accepts on update (fix "sticky accept")
ClosedPublic
Actions

Authored by epriestley on Apr 3 2017, 3:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 12:53 PM

	Unknown Object (File)
	Fri, May 3, 6:53 AM

	Unknown Object (File)
	Thu, Apr 25, 1:18 AM

	Unknown Object (File)
	Fri, Apr 19, 6:20 PM

	Unknown Object (File)
	Sun, Apr 7, 12:54 PM

	Unknown Object (File)
	Mar 30 2024, 3:05 PM

	Unknown Object (File)
	Feb 7 2024, 5:52 PM

	Unknown Object (File)
	Jan 23 2024, 9:48 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading

Commits

rP520d3b939204: (stable) Don't downgrade accepts on update (fix "sticky accept")
rP9ebb5f8cda56: Don't downgrade accepts on update (fix "sticky accept")

Summary

Fixes T12496. Sticky accept was accidentally impacted by the "void" changes in D17566.

Instead, don't always downgrade all accepts/rejects: on update, we only want to downgrade accepts.

Test Plan

With sticky accept off, updated an accepted revision: new state is "needs review".
With sticky accept on, updated an accepted revision: new state is "accepted" (sticky accept working correctly).
Did "reject" + "request review" to make sure that still works, worked fine.

Diff Detail

Repository

Branch

void1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16275
Build 21629: Run Core Tests
Build 21628: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2017, 3:38 PM

Harbormaster completed remote builds in B16275: Diff 42347.Apr 3 2017, 3:39 PM

chad accepted this revision.Apr 3 2017, 4:54 PM

This revision is now accepted and ready to land.Apr 3 2017, 4:54 PM

Closed by commit rP9ebb5f8cda56: Don't downgrade accepts on update (fix "sticky accept") (authored by epriestley, committed by epriestley). · Explain WhyApr 3 2017, 4:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

14 lines

xaction/

DifferentialRevisionVoidTransaction.php

6 lines

Diff 42347

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/xaction/DifferentialRevisionVoidTransaction.php

Loading...