Page MenuHomePhabricator

Count and report skipped documents from "bin/search index"
ClosedPublic

Authored by epriestley on Apr 2 2017, 4:20 PM.
Tags
None
Referenced Files
F14762021: D17597.diff
Thu, Jan 23, 4:17 AM
F14757980: D17597.id.diff
Wed, Jan 22, 4:19 AM
Unknown Object (File)
Tue, Jan 21, 1:02 PM
Unknown Object (File)
Tue, Jan 21, 9:38 AM
Unknown Object (File)
Dec 17 2024, 6:19 PM
Unknown Object (File)
Dec 15 2024, 4:41 PM
Unknown Object (File)
Dec 6 2024, 1:25 PM
Unknown Object (File)
Dec 4 2024, 12:20 AM
Subscribers
None

Details

Summary

Ref T12450. There's currently a bad behavior where inserting a document into one search service marks it as up to date everywhere.

This isn't nearly as obvious as it should be because bin/search index doesn't make it terribly clear when a document was skipped because the index version was already up to date.

When running bin/seach index without --force or --background, keep track of updated vs not-updated documents and print out some guidance. In other configurations, try to provide more help too.

Test Plan

Screen Shot 2017-04-02 at 9.17.23 AM.png (107×639 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Branch
search3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16253
Build 21597: Run Core Tests
Build 21596: arc lint + arc unit

Event Timeline

It's definitely not obvious that objects are skipped based on the object version rather than what's in the index. So yeah this is helpful.

This revision is now accepted and ready to land.Apr 2 2017, 8:44 PM