Page MenuHomePhabricator

Count and report skipped documents from "bin/search index"

Authored by epriestley on Apr 2 2017, 4:20 PM.
Referenced Files
F10766634: D17597.id42338.diff
Fri, May 27, 6:37 AM
Unknown Object (File)
Wed, May 25, 1:05 AM
Unknown Object (File)
Apr 10 2017, 8:25 AM
Unknown Object (File)
Apr 10 2017, 8:25 AM
Unknown Object (File)
Apr 10 2017, 8:24 AM
Unknown Object (File)
Apr 9 2017, 12:19 AM
Unknown Object (File)
Apr 5 2017, 7:03 AM
Unknown Object (File)
Apr 5 2017, 6:41 AM



Ref T12450. There's currently a bad behavior where inserting a document into one search service marks it as up to date everywhere.

This isn't nearly as obvious as it should be because bin/search index doesn't make it terribly clear when a document was skipped because the index version was already up to date.

When running bin/seach index without --force or --background, keep track of updated vs not-updated documents and print out some guidance. In other configurations, try to provide more help too.

Test Plan

Screen Shot 2017-04-02 at 9.17.23 AM.png (107×639 px, 30 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

It's definitely not obvious that objects are skipped based on the object version rather than what's in the index. So yeah this is helpful.

This revision is now accepted and ready to land.Apr 2 2017, 8:44 PM