Modernize PhortuneMerchant for Modular Transactions. Also changed the language of "Members" to "Managers", which I think fits better given the power/capability.
Details
Details
- Reviewers
epriestley - Commits
- rP28941b31059b: Update PhortuneMerchant to Modular Transactions
- Create a new Merchant
- Test not filling in a name, see error
- Test removing myself, see error
- Edit an existing Merchant
- Add new managers
- Test removing myself, see error
- Replace Picture
- Update various fields, contact info, email, footer
- Verify transactions are now nice and pretty
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- merchant-xaction (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16386 Build 21796: Run Core Tests Build 21795: arc lint + arc unit
Event Timeline
| src/applications/phortune/editor/PhortuneMerchantEditor.php | ||
|---|---|---|
| 20–21 | You can get rid of these, ModularTransactions figures them out automatically (part of the motivation is that you don't have to edit Editor -- or anything else in the upstream -- to add new transaction types). | |
| src/applications/phortune/storage/PhortuneMerchantTransaction.php | ||
| 17–19 | Can we avoid adding new types of mail tags? Per elsewhere, I believe things will work fine without this code: mail tags are not required, and we didn't have them before. | |
| src/applications/phortune/xaction/PhortuneMerchantInvoiceEmailTransaction.php | ||
| 73 | More correct as if (strlen(...)) | |
| 76 | Technically this one should probably be if (!strlen(...)). | |
| 77 | newInvalidError | |
| 85 | This should be newInvalidError(). Usage is:
The big difference is that newRequriedError() gets ignored if setContinueOnMissingFields(true) is set on the Editor. | |
| src/applications/phortune/xaction/PhortuneMerchantNameTransaction.php | ||
| 38 | This one is right ("required"). | |
| 47 | newInvalidError | |