Differential D17578

Make messages translatable and more sensible.
ClosedPublic
Actions

Authored by 20after4 on Mar 28 2017, 11:14 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP654f0f6043f8: Make messages translatable and more sensible.

Summary

These exception messages & comments didn't quite match reality.
Fixed and added pht() around a couple of them.

Test Plan

I didn't test this :P

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16214
Build 21530: Run Core Tests
Build 21529: arc lint + arc unit

Event Timeline

20after4 created this revision.Mar 28 2017, 11:14 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 28 2017, 11:14 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B16214: Diff 42288.Mar 28 2017, 11:15 PM

epriestley accepted this revision.Mar 28 2017, 11:16 PM

This revision is now accepted and ready to land.Mar 28 2017, 11:16 PM

Closed by commit rP654f0f6043f8: Make messages translatable and more sensible. (authored by 20after4, committed by 20after4). · Explain WhyMar 28 2017, 11:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

fulltextstorage/

PhabricatorElasticFulltextStorageEngine.php

3 lines

infrastructure/

cluster/

search/

PhabricatorSearchService.php

13 lines

Diff 42288

View Options

src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php