Page MenuHomePhabricator

Allow users to "Force accept" package reviews if they own a more general package
ClosedPublic

Authored by epriestley on Mar 28 2017, 4:51 PM.
Tags
None
Referenced Files
F15581810: D17569.id42267.diff
Wed, May 7, 1:21 PM
F15549340: D17569.id42273.diff
Sun, Apr 27, 5:08 AM
F15542837: D17569.id42266.diff
Fri, Apr 25, 7:15 PM
F15539647: D17569.id42267.diff
Fri, Apr 25, 3:13 AM
F15529936: D17569.id42273.diff
Tue, Apr 22, 11:37 PM
F15529446: D17569.id42266.diff
Tue, Apr 22, 7:55 PM
F15518171: D17569.id.diff
Sat, Apr 19, 11:34 AM
F15516547: D17569.diff
Fri, Apr 18, 7:38 PM
Subscribers
None

Details

Summary

Ref T12272. If you own a package which owns "/", this allows you to force-accept package reviews for packages which own sub-paths, like "/src/adventure/".

The default UI looks something like this:

[X] Accept as epriestley
[X] Accept as Root Package
[ ] Force accept as Adventure Package

By default, force-accepts are not selected.

(I may do some UI cleanup and/or annotate "because you own X" in the future and/or mark these accepts specially in some way, particularly if this proves confusing along whatever dimension.)

Test Plan

Screen Shot 2017-03-28 at 9.49.22 AM.png (289×747 px, 38 KB)

Diff Detail

Repository
rP Phabricator
Branch
review4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialChangeset.php:79XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16192
Build 21499: Run Core Tests
Build 21498: arc lint + arc unit

Event Timeline

  • Fix reject logic so it doesn't auto-force-reject everything you have authority-by-force over.
This revision is now accepted and ready to land.Mar 28 2017, 6:12 PM

me too buddy

I'll think a bit more about how we can, e.g., get test coverage here. All the pieces are kind of unwieldy and inherently interdependent and difficult to split apart. I haven't really come up with anything too promising yet. Maybe easier during/after T10574.

This revision was automatically updated to reflect the committed changes.