Page MenuHomePhabricator

Allow users to "Force accept" package reviews if they own a more general package
ClosedPublic

Authored by epriestley on Mar 28 2017, 4:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 12:23 AM
Unknown Object (File)
Sat, Apr 6, 6:10 PM
Unknown Object (File)
Thu, Apr 4, 2:55 PM
Unknown Object (File)
Mon, Apr 1, 11:35 PM
Unknown Object (File)
Fri, Mar 22, 6:13 PM
Unknown Object (File)
Mar 14 2024, 3:11 AM
Unknown Object (File)
Mar 10 2024, 1:38 PM
Unknown Object (File)
Mar 4 2024, 6:46 AM
Subscribers
None

Details

Summary

Ref T12272. If you own a package which owns "/", this allows you to force-accept package reviews for packages which own sub-paths, like "/src/adventure/".

The default UI looks something like this:

[X] Accept as epriestley
[X] Accept as Root Package
[ ] Force accept as Adventure Package

By default, force-accepts are not selected.

(I may do some UI cleanup and/or annotate "because you own X" in the future and/or mark these accepts specially in some way, particularly if this proves confusing along whatever dimension.)

Test Plan

Screen Shot 2017-03-28 at 9.49.22 AM.png (289×747 px, 38 KB)

Diff Detail

Repository
rP Phabricator
Branch
review4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialChangeset.php:79XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16191
Build 21497: Run Core Tests
Build 21496: arc lint + arc unit

Event Timeline

  • Fix reject logic so it doesn't auto-force-reject everything you have authority-by-force over.
This revision is now accepted and ready to land.Mar 28 2017, 6:12 PM

me too buddy

I'll think a bit more about how we can, e.g., get test coverage here. All the pieces are kind of unwieldy and inherently interdependent and difficult to split apart. I haven't really come up with anything too promising yet. Maybe easier during/after T10574.

This revision was automatically updated to reflect the committed changes.