Differential D17569

Allow users to "Force accept" package reviews if they own a more general package
ClosedPublic
Actions

Authored by epriestley on Mar 28 2017, 4:51 PM.

Details

Reviewers

chad

Maniphest Tasks

T12272: Allow users to accept on behalf of packages they control a containing package for

Commits

rP2fbc9a52da9b: Allow users to "Force accept" package reviews if they own a more general package

Summary

Ref T12272. If you own a package which owns "/", this allows you to force-accept package reviews for packages which own sub-paths, like "/src/adventure/".

The default UI looks something like this:

[X] Accept as epriestley
[X] Accept as Root Package
[ ] Force accept as Adventure Package

By default, force-accepts are not selected.

(I may do some UI cleanup and/or annotate "because you own X" in the future and/or mark these accepts specially in some way, particularly if this proves confusing along whatever dimension.)

Test Plan

Screen Shot 2017-03-28 at 9.49.22 AM.png (289×747 px, 38 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 28 2017, 4:51 PM

Harbormaster completed remote builds in B16191: Diff 42266.Mar 28 2017, 4:52 PM

Fix reject logic so it doesn't auto-force-reject everything you have authority-by-force over.

Harbormaster completed remote builds in B16192: Diff 42267.Mar 28 2017, 4:54 PM

noidea

This revision is now accepted and ready to land.Mar 28 2017, 6:12 PM

me too buddy

I'll think a bit more about how we can, e.g., get test coverage here. All the pieces are kind of unwieldy and inherently interdependent and difficult to split apart. I haven't really come up with anything too promising yet. Maybe easier during/after T10574.

Closed by commit rP2fbc9a52da9b: Allow users to "Force accept" package reviews if they own a more general package (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2017, 6:51 PM

This revision was automatically updated to reflect the committed changes.