Page MenuHomePhabricator
Differential D17568

When voiding "Accept" reviews, also void "Reject" reviews
ClosedPublic
Actions

Authored by epriestley on Mar 28 2017, 1:24 PM.
Tags
None
Referenced Files
F17832522: D17568.diff
Sat, Jul 26, 12:49 PM
Unknown Object (File)
Jun 17 2025, 8:30 AM
Unknown Object (File)
Jun 14 2025, 5:48 PM
Unknown Object (File)
Jun 7 2025, 11:31 AM
Unknown Object (File)
May 30 2025, 8:18 AM
Unknown Object (File)
May 30 2025, 5:22 AM
Unknown Object (File)
May 29 2025, 9:12 AM
Unknown Object (File)
May 28 2025, 11:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10967: Move Differential reviewers back to a dedicated database storage table
Commits
rPddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews
Summary

Ref T10967. This change is similar to D17566, but for rejects.

Test Plan
  • Create a revision as A, with reviewer B.
  • Reject as B.
  • Request review as A.
  • Before patch: stuck in "rejected".
  • After patch: transitions back to "needs review".

Diff Detail

Repository
rP Phabricator
Branch
review3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16190
Build 21495: Run Core Tests
Build 21494: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 28 2017, 1:24 PM
Harbormaster completed remote builds in B16190: Diff 42265.Mar 28 2017, 1:25 PM
chad accepted this revision.Mar 28 2017, 5:50 PM
This revision is now accepted and ready to land.Mar 28 2017, 5:50 PM
Closed by commit rPddc02ce420a5: When voiding "Accept" reviews, also void "Reject" reviews (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2017, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42265

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialReviewer.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionVoidTransaction.php

Loading...
Phabricator · Built by Phacility