Scope syntax css rules to direct descendants only in diffs
ClosedPublic
Actions

Authored by chad on Mar 27 2017, 5:24 PM.

Tags

None

Referenced Files

	F13147943: D17565.diff
	Fri, May 3, 7:03 PM

	F13146297: D17565.id42256.diff
	Fri, May 3, 9:48 AM

	F13142220: D17565.diff
	Fri, May 3, 5:51 AM

	Unknown Object (File)
	Wed, May 1, 10:59 PM

	Unknown Object (File)
	Thu, Apr 25, 12:58 AM

	Unknown Object (File)
	Sun, Apr 7, 4:27 AM

	Unknown Object (File)
	Mar 31 2024, 3:19 PM

	Unknown Object (File)
	Mar 30 2024, 1:57 PM

View All 83 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T11641: The at-mention of a disabled user renders a line instead of a dot for inline comments

Commits

rP9e2ab4f80e8c: Scope syntax css rules to direct descendants only in diffs

Summary

Fixes T11641. We're overbroad here (and this may need more scoping?) but this seems to resolve the immediate issue.

Test Plan

Upload a few diffs and ask disabled accounts to comment on them inline.

Diff Detail

Repository

rP Phabricator

Branch

span-diff-code (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16181
Build 21479: Run Core Tests
Build 21478: arc lint + arc unit

Event Timeline

chad created this revision.Mar 27 2017, 5:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 27 2017, 5:24 PM

epriestley accepted this revision.Mar 27 2017, 5:25 PM

This revision is now accepted and ready to land.Mar 27 2017, 5:25 PM

Harbormaster completed remote builds in B16181: Diff 42256.Mar 27 2017, 5:25 PM

Closed by commit rP9e2ab4f80e8c: Scope syntax css rules to direct descendants only in diffs (authored by chad, committed by chad). · Explain WhyMar 27 2017, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

css/

core/

syntax.css

2 lines

Diff 42256

View Options

resources/celerity/map.php