Ref T12270. These no longer have any callsites.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T12270: Unbeta Badges
- Commits
- rP080bf064c4a3: Remove obsolete Badges edge types
Used grep to search for each edge class constant, found no hits.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- badge2
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 16146 Build 21430: Run Core Tests Build 21429: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 39 ms | ManiphestTaskTestCase::Unknown Unit Message (" ") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-70/repo/phabricator/src/applications/badges/edge/PhabricatorRecipientHasBadgeEdgeType.php' failed!
#0 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/ba...')
#1 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
| |
| 35 ms | ManiphestTaskTestCase::Unknown Unit Message (" ") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-70/repo/phabricator/src/applications/badges/edge/PhabricatorRecipientHasBadgeEdgeType.php' failed!
#0 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/ba...')
#1 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
| |
| 6 ms | PhabricatorEdgeTestCase::Unknown Unit Message (" ") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-70/repo/phabricator/src/applications/badges/edge/PhabricatorRecipientHasBadgeEdgeType.php' failed!
#0 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/ba...')
#1 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
| |
| 0 ms | PhabricatorEdgeTypeTestCase::Unknown Unit Message (" ") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-70/repo/phabricator/src/applications/badges/edge/PhabricatorRecipientHasBadgeEdgeType.php' failed!
#0 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/ba...')
#1 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
| |
| 68 ms | PhabricatorFileTestCase::Unknown Unit Message (" ") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-70/repo/phabricator/src/applications/badges/edge/PhabricatorRecipientHasBadgeEdgeType.php' failed!
#0 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phabricator', 'applications/ba...')
#1 /core/data/drydock/workingcopy-70/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
| |
| View Full Test Results (29 Failed · 305 Passed) |
Event Timeline
Comment Actions
No, they use the constants explicitly, anticipating this change.
It will cause old award transactions to render "epriestley edited edges." or similar instead of "epriestley awarded this badge to chad.", but that's the only negative effect and I'm not planning to fix it since the app was beta when those awards happened.