Paginate the profile badges view
ClosedPublic
Actions

Authored by epriestley on Mar 24 2017, 9:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 7:51 PM

	Unknown Object (File)
	Thu, Nov 14, 11:50 PM

	Unknown Object (File)
	Sun, Nov 10, 7:07 PM

	Unknown Object (File)
	Sat, Nov 9, 1:15 PM

	Unknown Object (File)
	Sat, Nov 9, 1:15 PM

	Unknown Object (File)
	Sat, Nov 9, 1:15 PM

	Unknown Object (File)
	Thu, Nov 7, 4:27 AM

	Unknown Object (File)
	Tue, Nov 5, 11:46 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12270: Unbeta Badges

Commits

rP6f80a04699f8: Paginate the profile badges view

Summary

Ref T12270. Adds a pager, plus a few little cleanups from copy/paste and accumulated cruft.

Test Plan

Paginated a user with 180 badges.
Viewed a user with 0 badges.

Diff Detail

Repository

rP Phabricator

Branch

badge1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16145
Build 21428: Run Core Tests
Build 21427: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 24 2017, 9:01 PM

Harbormaster completed remote builds in B16145: Diff 42233.Mar 24 2017, 9:02 PM

shipitquick

This revision is now accepted and ready to land.Mar 24 2017, 9:03 PM

Closed by commit rP6f80a04699f8: Paginate the profile badges view (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2017, 9:11 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17360: Funbeta Badges.Mar 24 2017, 9:11 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileBadgesController.php

78 lines

Diff 42233

View Options

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php

Paginate the profile badges viewClosedPublicActions