Don't show the "Override Lock" prompt when creating objects
ClosedPublic
Actions

Authored by epriestley on Mar 23 2017, 12:43 PM.

Details

Reviewers

chad

Maniphest Tasks

T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task

Commits

rP1953ab98be2b: Don't show the "Override Lock" prompt when creating objects

Summary

Fixes T12369. When you create objects they may technically be locked: either because the default state is legitimately locked, or because the default policies prevent you from viewing so we sort of technically end in a locked state.

Regardless, don't prompt during creation, since this prompt isn't useful even if the lock detection is completely legitimate.

Test Plan

In Applications → Maniphest → Configure, set "Default View Policy" to "No One".
Tried to create a task.
Before patch: prompted to override lock.
After patch: no override prompt.

Diff Detail

Repository

rP Phabricator

Branch

task1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16102
Build 21367: Run Core Tests
Build 21366: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 23 2017, 12:43 PM

Harbormaster completed remote builds in B16102: Diff 42187.Mar 23 2017, 12:45 PM

Done that manually but test didn't pass. Only way on new task to not show Locked message is to apply policy as fallows:

Default View Policy All Users 
Default Edit Policy Subscribers

chad accepted this revision.Mar 23 2017, 1:37 PM

This revision is now accepted and ready to land.Mar 23 2017, 1:37 PM

@d.maznekov If you believe this patch doesn't completely resolve the issue, please wait for it to land, upgrade to HEAD of master so your install has the change, then file a new bug report with clear, complete reproduction instructions which allow us to reproduce the issue you're seeing on a fresh install of Phabricator. Anything other than complete reproduction instructions will not result in upstream changes.