Differential D17528

Provide a 'no dashboards' fallback state if you can't add any
ClosedPublic
Actions

Authored by chad on Mar 21 2017, 6:28 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T10390: Dashboards v2 (UX)

Commits

rP5e423c5fe021: Provide a 'no dashboards' fallback state if you can't add any

Summary

Ref T10390. Catch if the user doesn't have any dashboards they can edit and give them a helpful message instead.

Test Plan

Clean install, no dashboards, Click "Add to Dashboard" on ApplicationSearch results, see no dashboards message

Diff Detail

Repository

rP Phabricator

Branch

no-dashboards (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16075
Build 21324: Run Core Tests
Build 21323: arc lint + arc unit

Event Timeline

chad created this revision.Mar 21 2017, 6:28 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 21 2017, 6:28 PM

Harbormaster completed remote builds in B16075: Diff 42160.Mar 21 2017, 6:29 PM

epriestley accepted this revision.Mar 21 2017, 6:42 PM

This revision is now accepted and ready to land.Mar 21 2017, 6:42 PM

Closed by commit rP5e423c5fe021: Provide a 'no dashboards' fallback state if you can't add any (authored by chad, committed by chad). · Explain WhyMar 21 2017, 6:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardQueryPanelInstallController.php

14 lines

Diff 42160

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Provide a 'no dashboards' fallback state if you can't add anyClosedPublicActions