Page MenuHomePhabricator

Add Dashboards as a default pinned application
ClosedPublic

Authored by chad on Mar 21 2017, 5:41 PM.
Tags
None
Referenced Files
F14074404: D17527.diff
Thu, Nov 21, 6:31 AM
F14074283: D17527.diff
Thu, Nov 21, 5:39 AM
Unknown Object (File)
Sat, Nov 16, 9:22 PM
Unknown Object (File)
Wed, Nov 13, 10:38 PM
Unknown Object (File)
Sun, Nov 10, 12:27 PM
Unknown Object (File)
Mon, Nov 4, 10:01 PM
Unknown Object (File)
Thu, Oct 24, 9:30 AM
Unknown Object (File)
Oct 20 2024, 7:56 AM
Subscribers

Details

Summary

Ref T10390. Dashboard usability is high enough that I think we should pin it by default for users to create custom home pages.

Test Plan

Review order of applications in sandbox.

Diff Detail

Repository
rP Phabricator
Branch
install-dash-app (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/dashboard/application/PhabricatorDashboardApplication.php:23XHP62Class Name Literal
Unit
Tests Passed
Build Status
Buildable 16071
Build 21318: Run Core Tests
Build 21317: arc lint + arc unit

Event Timeline

This feels like a fairly advanced application for normal users to me and I think setup/NUX already guides admins to it, but I don't feel strongly.

src/applications/dashboard/application/PhabricatorDashboardApplication.php
22

I think you can just return true;, we won't pin un-installed applications.

This revision is now accepted and ready to land.Mar 21 2017, 6:02 PM
This revision was automatically updated to reflect the committed changes.