Page MenuHomePhabricator

Add Dashboards as a default pinned application
ClosedPublic

Authored by chad on Mar 21 2017, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 10:14 PM
Unknown Object (File)
Fri, May 3, 7:24 AM
Unknown Object (File)
Thu, Apr 25, 1:31 AM
Unknown Object (File)
Sat, Apr 20, 9:16 PM
Unknown Object (File)
Thu, Apr 11, 9:04 AM
Unknown Object (File)
Thu, Apr 11, 4:22 AM
Unknown Object (File)
Apr 2 2024, 11:19 AM
Unknown Object (File)
Mar 30 2024, 12:21 PM
Subscribers

Details

Summary

Ref T10390. Dashboard usability is high enough that I think we should pin it by default for users to create custom home pages.

Test Plan

Review order of applications in sandbox.

Diff Detail

Repository
rP Phabricator
Branch
install-dash-app (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/dashboard/application/PhabricatorDashboardApplication.php:23XHP62Class Name Literal
Unit
Tests Passed
Build Status
Buildable 16071
Build 21318: Run Core Tests
Build 21317: arc lint + arc unit

Event Timeline

This feels like a fairly advanced application for normal users to me and I think setup/NUX already guides admins to it, but I don't feel strongly.

src/applications/dashboard/application/PhabricatorDashboardApplication.php
22

I think you can just return true;, we won't pin un-installed applications.

This revision is now accepted and ready to land.Mar 21 2017, 6:02 PM
This revision was automatically updated to reflect the committed changes.