Ref T10390. I find myself wanting to find dashboards I can edit, even if I am not the author. I think this is useful for larger installs with multiple admins. Also make disabled Dashboards more grey in UI results.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T10390: Dashboards v2 (UX)
- Commits
- rP7d4c0f002f11: Allow searching Dashboards by Editable
Log in a test user, create a dashboard with I cannot edit. Log into my account, search for editable dashboards and only see mine. Set dashboard to all users, search under test account and see editable dashboards.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboard-query-editable (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16065 Build 21308: Run Core Tests Build 21307: arc lint + arc unit
Event Timeline
Comment Actions
Performance on this kind of application-level policy filtered query can be pretty bad, but I don't really see a way to provide this feature otherwise.
The "overheat" limit is currently 10x the page size, so if an install has 1,000 dashboards you can not edit before any you can, this UI will become useless (i.e., take a moderately long time to give you an "overheated" error with no results). If it has 1,000 dashboards you can not edit and all the dashboards you can edit do not appear in the first 1,000 results, you will not be able to find the other dashboards with this UI. (These issues also apply to the <select /> input on the "Add Query to Dashboard" workflow.)
We could change the edit policy to an explicit list of users or something, but that doesn't seem like a very good way forward.
I'm not quite sure why/when you want to find dashboards you can edit offhand, other than for the "Add Query to Dashboard" flow. Maybe first we should try destroying every dashboard on this install which isn't installed on any user's homepage, and see where that leaves us? I think there's so much "Copy of Copy of New Simple Dashboard Test" on this install that it's hard to get a great sense of things.
I'm fine with this regardless since it's well-contained and small, but it feels like it might not be the best solution to whatever problems it solves.
| src/applications/dashboard/query/PhabricatorDashboardQuery.php | ||
|---|---|---|
| 69–78 | This should do this instead, to batch the policy checks: $dashboards = id(new PhabricatorPolicyFilter()) ->setViewer(...) ->requireCapabilities(...) ->apply($dashboards); If you loop instead of passing a list to PolicyFilter, we can end up with a bunch of single-gets for project policies. | |
Comment Actions
I think the core problem is I want to find all dashboards I'm responsible for. As a user this doesn't mean much but with admins, facts, projects I think there are cases where I'll be responsible for a small handful.
Comment Actions
If we had like 10 employees and facts / project dashboards, "stuff you can edit" (~every project/fact dashboard) would probably be a huge superset of "stuff you're responsible for" (only a couple of them).
We could let you subscribe to dashboards, or improve Flag support, or add some kind of explicit "I care about this" action to dashboards, maybe.