Page MenuHomePhabricator

Store "last comment" and "last action" diffs on reviewers
ClosedPublic

Authored by epriestley on Mar 20 2017, 5:01 PM.

Details

Summary

Ref T10967. We have a "commented" state to help reviewers get a better sense of who is part of a discussion, and a "last action" state to help distinguish between "accept" and "accepted an older version", for the purposes of sticky accepts and as a UI hint.

Currently, these are first-class states, partly beacuse we were somewhat limited in what we could do with edges. However, a more flexible way to represent them is as flags separate from the primary state flag.

In the new storage, write them as separate state information: lastActionDiffPHID stores the Diff PHID of the last review action (accept, reject, etc). lastCommentDiffPHID stores the Diff PHID of the last comment (top-level or inline).

Test Plan

Applied storage changes, commented and acted on a revision. Saw appropriate state reflected in the database.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 20 2017, 5:01 PM
chad accepted this revision.Mar 20 2017, 6:15 PM
This revision is now accepted and ready to land.Mar 20 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.