Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
F19357509: D17508.id42113.diff
Fri, Dec 26, 7:51 AM
F19303448: D17508.id42114.diff
Wed, Dec 24, 1:00 AM
F19297876: D17508.id.diff
Tue, Dec 23, 1:03 PM
F19260270: D17508.diff
Mon, Dec 22, 3:43 PM
F19097033: D17508.id42114.diff
Thu, Dec 4, 12:07 PM
F19097025: D17508.id42113.diff
Thu, Dec 4, 12:04 PM
F19096756: D17508.diff
Thu, Dec 4, 10:58 AM
F18843290: D17508.diff
Oct 28 2025, 9:13 PM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable