Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
F12844250: D17508.id.diff
Thu, Mar 28, 11:22 PM
Unknown Object (File)
Thu, Mar 7, 1:57 AM
Unknown Object (File)
Feb 3 2024, 3:09 PM
Unknown Object (File)
Jan 23 2024, 8:54 PM
Unknown Object (File)
Jan 15 2024, 3:56 PM
Unknown Object (File)
Jan 13 2024, 8:10 AM
Unknown Object (File)
Jan 5 2024, 10:04 PM
Unknown Object (File)
Dec 30 2023, 7:15 AM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable