Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 1:49 PM
Unknown Object (File)
Fri, Jan 24, 10:54 AM
Unknown Object (File)
Fri, Jan 24, 7:14 AM
Unknown Object (File)
Thu, Jan 23, 8:59 PM
Unknown Object (File)
Thu, Jan 23, 8:59 PM
Unknown Object (File)
Thu, Jan 23, 8:59 PM
Unknown Object (File)
Wed, Jan 22, 11:40 AM
Unknown Object (File)
Tue, Jan 21, 11:59 AM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable