Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"

Authored by epriestley on Mar 19 2017, 12:32 AM.



Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 19 2017, 12:32 AM
avivey accepted this revision.Mar 19 2017, 12:51 AM
This revision is now accepted and ready to land.Mar 19 2017, 12:51 AM
This revision was automatically updated to reflect the committed changes.