Page MenuHomePhabricator

Don't use "--" to separate flags and arguments in "git ls-remote"
ClosedPublic

Authored by epriestley on Mar 19 2017, 12:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 19, 5:31 PM
Unknown Object (File)
Sat, Jun 6, 2:11 PM
Unknown Object (File)
Apr 12 2026, 2:09 AM
Unknown Object (File)
Apr 2 2026, 3:25 PM
Unknown Object (File)
Jan 31 2026, 12:30 PM
Unknown Object (File)
Jan 23 2026, 2:23 AM
Unknown Object (File)
Jan 14 2026, 5:34 PM
Unknown Object (File)
Dec 26 2025, 7:51 AM
Subscribers
None

Details

Summary

Fixes T12416. See that task for discussion. Slightly older versions of git do not appear to support use of -- to separate flags and arguments.

Test Plan
  • Ran bin/repository update PHABX.
  • In T12416, had a user with Git 2.1.4 confirm that git ls-remote X worked while git ls-remote -- X failed.
  • Read git help ls-remote to look for any kind of suspicious --destroy-the-world flags, didn't see any that made me uneasy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable