Page MenuHomePhabricator

Make "bin/config set --database ..." resurrect deleted values
ClosedPublic

Authored by epriestley on Mar 16 2017, 6:59 PM.
Tags
None
Referenced Files
F13148505: D17506.diff
Sat, May 4, 1:37 AM
F13145630: D17506.diff
Fri, May 3, 9:13 AM
F13141944: D17506.diff
Fri, May 3, 5:23 AM
Unknown Object (File)
Thu, Apr 25, 2:50 AM
Unknown Object (File)
Thu, Apr 11, 10:12 AM
Unknown Object (File)
Mon, Apr 8, 8:03 AM
Unknown Object (File)
Mar 30 2024, 9:06 PM
Unknown Object (File)
Mar 4 2024, 9:55 PM
Subscribers
None

Details

Summary

Fixes T12409. Config entries may be marked as "deleted", and bin/config set --database doesn't un-delete them, so the edit doesn't do anything.

The "most correct" fix here is to swap to transactions so we run the same code, but just fix this narrowly for now since it's one line of code.

Test Plan
  • Set maniphest.default-priority to 123.
  • Deleted maniphest.default-priority from the web UI by deleting all the text in the box.
  • Before patch: bin/config set --database maniphest.default-priority 789 had no effect.
  • After patch: bin/config set --database maniphest.default-priority 789 worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable