HomePhabricator

Add ActionIcon to PHUIListItemView, use in Dashboards

Tags
None
Referenced Files
F4136699: pasted_file
Mar 16 2017, 6:32 PM
Subscribers
None

Description

Add ActionIcon to PHUIListItemView, use in Dashboards

Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover.

Test Plan:
Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works.

pasted_file (718×664 px, 73 KB)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17505

Details

Provenance
Chad Little <chad@phacility.com>Authored on Mar 16 2017, 6:32 PM
chadPushed on Mar 16 2017, 6:32 PM
Reviewer
epriestley
Differential Revision
D17505: Add ActionIcon to PHUIListItemView, use in Dashboards
Parents
rP19af10df3706: Apply the wordwrap() hack for "To" to PHPMailerLite
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16006
Build 21221: Run Core Tests