Page MenuHomePhabricator

Prevent use of the "quality" constraint in the Badge search API
ClosedPublic

Authored by epriestley on Mar 9 2017, 7:43 PM.
Tags
None
Referenced Files
F14082514: D17487.diff
Sat, Nov 23, 12:09 AM
Unknown Object (File)
Thu, Nov 21, 3:40 AM
Unknown Object (File)
Sun, Nov 17, 2:03 AM
Unknown Object (File)
Thu, Nov 14, 7:10 PM
Unknown Object (File)
Wed, Nov 13, 7:54 AM
Unknown Object (File)
Sun, Nov 10, 8:24 AM
Unknown Object (File)
Sat, Nov 9, 1:06 PM
Unknown Object (File)
Fri, Nov 1, 5:16 AM
Subscribers
None

Details

Summary

Ref T12270. This just drops the constraint for now, rather than dealing with all the typecasting stuff and putting us in a position which will almost certainly require backward compatibility breaks in the future.

Also renames "badges.*" to "badge.*" for consistency (all other methods are singular: token.*, project.*, differential.revision.*, etc).

Test Plan

Saw "qualities" now "Not Supported", while other constraints continue to work:

Screen Shot 2017-03-09 at 11.42.36 AM.png (70×535 px, 13 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 9 2017, 7:51 PM
This revision was automatically updated to reflect the committed changes.