Page MenuHomePhabricator

Fourth fix for the magical world of crumbs and text-overflow
ClosedPublic

Authored by chad on Mar 9 2017, 1:48 AM.
Tags
None
Referenced Files
F15465952: D17483.id42041.diff
Thu, Apr 3, 12:29 AM
F15465356: D17483.id42045.diff
Wed, Apr 2, 5:45 PM
F15463042: D17483.id42042.diff
Tue, Apr 1, 8:01 PM
F15461090: D17483.id.diff
Tue, Apr 1, 5:07 AM
F15458866: D17483.diff
Mon, Mar 31, 7:57 AM
F15426832: D17483.id42042.diff
Sun, Mar 23, 10:59 AM
F15414290: D17483.id42041.diff
Thu, Mar 20, 12:00 AM
F15414260: D17483.id42042.diff
Wed, Mar 19, 11:45 PM
Subscribers

Details

Summary

The Safari hack in place casued a truncation issue in Firefox, so that hack is now gone. Instead the bug appears to be the creative inclusion of "space". In fiddling with this adding one space inside the span and one space outside the span seems to resolve all cases.

Test Plan

Chrome, Safari, Firefox. Test "hector" and copy paste of a Task ID.

Diff Detail

Repository
rP Phabricator
Branch
crumbs-fix-140b (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15948
Build 21126: Run Core Tests
Build 21125: arc lint + arc unit