Paths

Table of Contentst

Add quality and icon to Badge Lipsum generator
ClosedPublic
Actions

Authored by chad on Mar 6 2017, 7:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 6:58 PM

	Unknown Object (File)
	Sun, Dec 15, 10:40 PM

	Unknown Object (File)
	Thu, Dec 5, 11:10 PM

	Unknown Object (File)
	Thu, Dec 5, 3:18 PM

	Unknown Object (File)
	Wed, Dec 4, 9:34 PM

	Unknown Object (File)
	Tue, Dec 3, 11:02 AM

	Unknown Object (File)
	Mon, Dec 2, 11:39 AM

	Unknown Object (File)
	Wed, Nov 27, 7:50 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP814c28d39a81: Add quality and icon to Badge Lipsum generator

Summary

This just adds a few more dimensions to the generator.

Test Plan

run bin/lipsum generate badges, verify new icons and quality work.

Diff Detail

Repository

rP Phabricator

Branch

badge-lipsum (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15926
Build 21090: Run Core Tests
Build 21089: arc lint + arc unit

Event Timeline

chad created this revision.Mar 6 2017, 7:30 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 6 2017, 7:30 PM

Harbormaster completed remote builds in B15926: Diff 42020.Mar 6 2017, 7:31 PM

epriestley accepted this revision.Mar 6 2017, 7:39 PM

This revision is now accepted and ready to land.Mar 6 2017, 7:39 PM

Closed by commit rP814c28d39a81: Add quality and icon to Badge Lipsum generator (authored by chad, committed by chad). · Explain WhyMar 6 2017, 7:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

lipsum/

PhabricatorBadgesBadgeTestDataGenerator.php

24 lines

Diff 42020

View Options

src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php

Add quality and icon to Badge Lipsum generatorClosedPublicActions