D17474.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D17474.diff
View Options

	diff --git a/src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php b/src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php
	--- a/src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php
	+++ b/src/applications/badges/lipsum/PhabricatorBadgesBadgeTestDataGenerator.php
	@@ -12,7 +12,7 @@
	public function generateObject() {
	$author = $this->loadRandomUser();

	- list($name, $description) = $this->newLoot();
	+ list($name, $description, $quality, $icon) = $this->newLoot();

	$xactions = array();

	@@ -26,6 +26,16 @@
	'value' => $description,
	);

	+ $xactions[] = array(
	+ 'type' => 'quality',
	+ 'value' => (string)$quality,
	+ );
	+
	+ $xactions[] = array(
	+ 'type' => 'icon',
	+ 'value' => $icon,
	+ );
	+
	$params = array(
	'transactions' => $xactions,
	);
	@@ -58,7 +68,17 @@

	$drop = preg_replace($effect_pattern, '', $drop);

	- return array($drop, $description);
	+ $quality_map = PhabricatorBadgesQuality::getQualityMap();
	+ shuffle($quality_map);
	+ $quality = head($quality_map);
	+ $rarity = $quality['rarity'];
	+
	+ $icon_map = id(new PhabricatorBadgesIconSet())->getIcons();
	+ shuffle($icon_map);
	+ $icon_map = head($icon_map);
	+ $icon = $icon_map->getKey();
	+
	+ return array($drop, $description, $rarity, $icon);
	}

	public function rollDropValue($matches) {