Page MenuHomePhabricator

Update tasks/commits, remove diffs from Profile
ClosedPublic

Authored by chad on Mar 6 2017, 5:58 PM.
Tags
None
Referenced Files
F13172858: D17470.diff
Tue, May 7, 5:29 PM
Unknown Object (File)
Thu, Apr 25, 3:21 AM
Unknown Object (File)
Mon, Apr 22, 9:48 AM
Unknown Object (File)
Thu, Apr 11, 10:42 AM
Unknown Object (File)
Apr 7 2024, 3:09 AM
Unknown Object (File)
Mar 31 2024, 3:12 PM
Unknown Object (File)
Mar 31 2024, 3:11 PM
Unknown Object (File)
Mar 31 2024, 3:11 PM
Subscribers

Details

Summary

Mostly a minor nit-pick, but I hate sending users off the profile and disorient them onto application search. These pages are pretty easy to maintain, I don't expect to need to do more here. I dropped Differential outright. Kept Tasks and Commits. Now you can browse everything about a user on their profile without leaving. Maybe add a link to ApplicationSearch? Not sure it's important.

Test Plan

Review tasks and commits on mine and other user profiles.

Diff Detail

Repository
rP Phabricator
Branch
profile-tasks (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15918
Build 21078: Run Core Tests
Build 21077: arc lint + arc unit

Event Timeline

The value of keeping users on the profile seems lower to me than the value of having ApplicationSearch constraints to filter things, but I don't feel strongly.

This revision is now accepted and ready to land.Mar 6 2017, 6:10 PM

I never find these useful, offhand, but if I wanted to search for someone's tasks, I'd just outright use ApplicationSearch. At least here, if I'm on a Profile to learn about someone, I'm kept at the source.

This revision was automatically updated to reflect the committed changes.