Page MenuHomePhabricator

Update tasks/commits, remove diffs from Profile
ClosedPublic

Authored by chad on Mar 6 2017, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 8:27 PM
Unknown Object (File)
Sat, Dec 7, 4:46 PM
Unknown Object (File)
Sat, Dec 7, 2:48 PM
Unknown Object (File)
Thu, Dec 5, 7:12 PM
Unknown Object (File)
Tue, Dec 3, 11:50 AM
Unknown Object (File)
Nov 28 2024, 7:30 AM
Unknown Object (File)
Nov 17 2024, 12:23 PM
Unknown Object (File)
Nov 9 2024, 1:03 PM
Subscribers

Details

Summary

Mostly a minor nit-pick, but I hate sending users off the profile and disorient them onto application search. These pages are pretty easy to maintain, I don't expect to need to do more here. I dropped Differential outright. Kept Tasks and Commits. Now you can browse everything about a user on their profile without leaving. Maybe add a link to ApplicationSearch? Not sure it's important.

Test Plan

Review tasks and commits on mine and other user profiles.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The value of keeping users on the profile seems lower to me than the value of having ApplicationSearch constraints to filter things, but I don't feel strongly.

This revision is now accepted and ready to land.Mar 6 2017, 6:10 PM

I never find these useful, offhand, but if I wanted to search for someone's tasks, I'd just outright use ApplicationSearch. At least here, if I'm on a Profile to learn about someone, I'm kept at the source.

This revision was automatically updated to reflect the committed changes.