Page MenuHomePhabricator

Add limit (maximum simultaneous commands) and throttle (delay between commands) to Phage
ClosedPublic

Authored by epriestley on Feb 22 2017, 9:49 PM.
Tags
None
Referenced Files
F14042948: D17396.diff
Tue, Nov 12, 7:03 AM
F14005578: D17396.diff
Sun, Oct 27, 4:04 PM
F13957061: D17396.diff
Oct 14 2024, 8:15 AM
Unknown Object (File)
Sep 18 2024, 1:39 PM
Unknown Object (File)
Sep 5 2024, 11:03 PM
Unknown Object (File)
Aug 30 2024, 4:15 AM
Unknown Object (File)
Aug 28 2024, 3:00 AM
Unknown Object (File)
Aug 27 2024, 1:32 PM
Subscribers
None

Details

Summary

Ref T12218. Ref T2794. This just provides a couple of general purpose tools to slow Phage down a bit if the speed is getting TOO EXTREME.

In particular, secure updates from itself so if all 4 nodes get hit simultaneously the deploy doesn't work. It deploys cleanly with --limit 1.

A separate change to the phage remote workflow in Instances exposes these options as flags:

  • --limit: Run only this many commands simultaneously.
  • --throttle: Wait this long between starting commands (for example, --throttle 0.25 will only start 4 commands per second).
Test Plan
  • Ran phage remote status on secure with various --throttle and --limit arguments, and without any arguments.
  • Ran phage remote upgrade --limit 1 on secure, got a clean upgrade.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable