Page MenuHomePhabricator

Add limit (maximum simultaneous commands) and throttle (delay between commands) to Phage
ClosedPublic

Authored by epriestley on Feb 22 2017, 9:49 PM.
Tags
None
Referenced Files
F19854715: D17396.diff
Fri, Mar 13, 10:30 AM
F19825466: D17396.id41833.diff
Sun, Mar 8, 11:50 AM
F19824617: D17396.id41833.diff
Sun, Mar 8, 1:27 AM
F19810774: D17396.id41833.diff
Tue, Mar 3, 9:06 PM
F18812372: D17396.diff
Oct 20 2025, 8:52 AM
F18755971: D17396.id41833.diff
Oct 5 2025, 8:25 AM
F18755069: D17396.id.diff
Oct 5 2025, 3:25 AM
F18705688: D17396.diff
Sep 28 2025, 12:38 PM
Subscribers
None

Details

Summary

Ref T12218. Ref T2794. This just provides a couple of general purpose tools to slow Phage down a bit if the speed is getting TOO EXTREME.

In particular, secure updates from itself so if all 4 nodes get hit simultaneously the deploy doesn't work. It deploys cleanly with --limit 1.

A separate change to the phage remote workflow in Instances exposes these options as flags:

  • --limit: Run only this many commands simultaneously.
  • --throttle: Wait this long between starting commands (for example, --throttle 0.25 will only start 4 commands per second).
Test Plan
  • Ran phage remote status on secure with various --throttle and --limit arguments, and without any arguments.
  • Ran phage remote upgrade --limit 1 on secure, got a clean upgrade.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable