Page MenuHomePhabricator

Add limit (maximum simultaneous commands) and throttle (delay between commands) to Phage
ClosedPublic

Authored by epriestley on Feb 22 2017, 9:49 PM.
Tags
None
Referenced Files
F14967752: D17396.diff
Sun, Feb 16, 10:06 AM
Unknown Object (File)
Wed, Feb 12, 2:59 AM
Unknown Object (File)
Sun, Feb 9, 3:20 AM
Unknown Object (File)
Sun, Feb 9, 3:20 AM
Unknown Object (File)
Sun, Feb 9, 3:20 AM
Unknown Object (File)
Thu, Feb 6, 3:42 AM
Unknown Object (File)
Tue, Feb 4, 9:09 AM
Unknown Object (File)
Fri, Jan 31, 11:06 AM
Subscribers
None

Details

Summary

Ref T12218. Ref T2794. This just provides a couple of general purpose tools to slow Phage down a bit if the speed is getting TOO EXTREME.

In particular, secure updates from itself so if all 4 nodes get hit simultaneously the deploy doesn't work. It deploys cleanly with --limit 1.

A separate change to the phage remote workflow in Instances exposes these options as flags:

  • --limit: Run only this many commands simultaneously.
  • --throttle: Wait this long between starting commands (for example, --throttle 0.25 will only start 4 commands per second).
Test Plan
  • Ran phage remote status on secure with various --throttle and --limit arguments, and without any arguments.
  • Ran phage remote upgrade --limit 1 on secure, got a clean upgrade.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable