Page MenuHomePhabricator

Add limit (maximum simultaneous commands) and throttle (delay between commands) to Phage
ClosedPublic

Authored by epriestley on Feb 22 2017, 9:49 PM.
Tags
None
Referenced Files
F18755971: D17396.id41833.diff
Sun, Oct 5, 8:25 AM
F18755069: D17396.id.diff
Sun, Oct 5, 3:25 AM
F18705688: D17396.diff
Sun, Sep 28, 12:38 PM
F18646172: D17396.id41833.diff
Fri, Sep 19, 9:40 AM
F18586325: D17396.diff
Sep 11 2025, 6:17 PM
F18508556: D17396.id.diff
Sep 5 2025, 2:53 AM
F18500629: D17396.diff
Sep 4 2025, 9:12 PM
F18427100: D17396.diff
Aug 30 2025, 11:44 PM
Subscribers
None

Details

Summary

Ref T12218. Ref T2794. This just provides a couple of general purpose tools to slow Phage down a bit if the speed is getting TOO EXTREME.

In particular, secure updates from itself so if all 4 nodes get hit simultaneously the deploy doesn't work. It deploys cleanly with --limit 1.

A separate change to the phage remote workflow in Instances exposes these options as flags:

  • --limit: Run only this many commands simultaneously.
  • --throttle: Wait this long between starting commands (for example, --throttle 0.25 will only start 4 commands per second).
Test Plan
  • Ran phage remote status on secure with various --throttle and --limit arguments, and without any arguments.
  • Ran phage remote upgrade --limit 1 on secure, got a clean upgrade.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable