Differential D17393

Simplify dashboard panel creation
ClosedPublic
Actions

Authored by chad on Feb 22 2017, 12:34 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T10390: Dashboards v2 (UX)

Commits

rP568a3877d17b: Simplify dashboard panel creation

Summary

Ref T10390. Basically hides policy controls when creating a panel on a dashboard. Shows when you edit them or through normal workflow. I think we should maybe also get rid of view policy? Not sure the benefit since results will be filtered anyways. Maybe Text panels? Not sure the use case.

Test Plan

Add a panel, edit a panel.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 22 2017, 12:34 AM

Harbormaster completed remote builds in B15718: Diff 41821.Feb 22 2017, 12:34 AM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 22 2017, 12:34 AM

Harbormaster completed remote builds in B15718: Diff 41821.Feb 22 2017, 12:35 AM

hskiba added a subscriber: hskiba.Feb 22 2017, 8:02 AM

I think this is sort of a bad version of "bind panels to dashboards", but I guess I can counter-diff you for that eventually.

This revision is now accepted and ready to land.Feb 22 2017, 4:32 PM

I'm not sure how to get rid of panel creation outside of Dashboards. Tab Panel workflow still needs them. I think we can get around that by re-thinking that creation workflow.

Closed by commit rP568a3877d17b: Simplify dashboard panel creation (authored by chad, committed by chad). · Explain WhyFeb 23 2017, 1:50 AM

This revision was automatically updated to reflect the committed changes.