Page MenuHomePhabricator

Add PhageActions to libphutil
ClosedPublic

Authored by epriestley on Feb 17 2017, 11:14 PM.
Tags
None
Referenced Files
F19142551: D17380.id41789.diff
Wed, Dec 10, 1:49 PM
F19103433: D17380.id.diff
Fri, Dec 5, 10:09 AM
F19099308: D17380.diff
Thu, Dec 4, 7:36 PM
F18839446: D17380.id.diff
Oct 27 2025, 4:29 PM
F18739461: D17380.diff
Oct 1 2025, 9:34 PM
F18636387: D17380.diff
Sep 17 2025, 4:03 AM
F18628900: D17380.id41790.diff
Sep 16 2025, 7:32 AM
F18606302: D17380.id41798.diff
Sep 13 2025, 10:02 PM
Subscribers
None

Details

Summary

Ref T2794. I'm not 100% sold on the design of this and it doesn't interact with any other code yet, but get deployment-related code upstream.

The overall approach I'm taking here is that you build a "plan", which is like a DOM tree of stuff you want to do, then execute the plan.

The only plan we build or execute right now goes like this:

  • Phage Plan
    • Launch a local Phage agent
      • Have that agent run a bunch of commands

...but I think this approach should be flexible enough to accommodate more complicated deployment processes in the future.

Test Plan

Successfully deployed secure without typing a bunch of different commands.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Don't write unconditionally to the debug logfile (I'll add some flags for this later).
This revision is now accepted and ready to land.Feb 17 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.