Page MenuHomePhabricator

Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 17 2017, 5:32 PM.
Tags
None
Referenced Files
F14448336: D17376.diff
Thu, Dec 26, 4:37 PM
F14444008: D17376.diff
Thu, Dec 26, 10:39 AM
Unknown Object (File)
Wed, Dec 18, 2:15 PM
Unknown Object (File)
Wed, Dec 11, 4:20 PM
Unknown Object (File)
Mon, Dec 9, 7:53 PM
Unknown Object (File)
Sat, Dec 7, 3:58 AM
Unknown Object (File)
Fri, Dec 6, 4:07 PM
Unknown Object (File)
Fri, Dec 6, 2:12 AM
Subscribers

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 15677
Build 20706: Run Core Tests
Build 20705: arc lint + arc unit

Unit TestsFailed

TimeTest
449 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
28 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
35 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
7 assertions passed.
12 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
14 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 294 Passed · 67 Skipped)

Event Timeline

This revision is now accepted and ready to land.Feb 17 2017, 5:44 PM
This revision was automatically updated to reflect the committed changes.