Make the new "Unverified Email" behavior more clear to other users
ClosedPublic

Authored by epriestley on Fri, Feb 17, 3:25 PM.

Details

Summary

Ref T12268. Ref T12157. When you mention or interact with a user who is unlikely to be able to respond (for example, because their account is disabled), we try to show a colored dot to provide a hint about this.

Recently, we no longer send any normal mail to unverified addresses. However, the rules for showing a dot haven't been updated yet, so they only care about this if auth.require-verification is set. This can be misleading, because if you say Hey @alice, what do you think about this? and she hasn't verified her email, you may not get a response.

Update the rule so users with unverified email addresses get a grey dot in all cases. The hint is basically "you shouldn't expect a response from this user".

Make the meaning of this hint more clear on the hovercard and profile.

Also:

  • Allow the non-ajax version of the hovercard page (which is basically only useful for testing hovercards) accept ?names=... so you can just plug usernames, hashtags, etc., in there.
  • Fix a bug where the user's join date was based on their profile creation date instead of account creation date on the hovercard. Users may not have a profile creation date (if they never changed any account details), and it may be different from their account creation date.
Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
epriestley created this revision.Fri, Feb 17, 3:25 PM

This changes the default style (when a user has no special attributes) a little bit by using setTag() on the header and causing it to render with a full tag/background/shade. I think it looks pretty good as-is and wanted to get the color there for "Disabled", but happy to tweak design stuff if you don't love it.

chad added a comment.Fri, Feb 17, 5:20 PM

can we fix "Availability" too? Is became misaligned sometime with calendar changes.

chad accepted this revision.Fri, Feb 17, 5:21 PM

I was planning on redesigning the user cards, so ship this if you want all these features and I'll clean it up next week.

This revision is now accepted and ready to land.Fri, Feb 17, 5:21 PM

Yeah, I punted on "Availability" since I figure Hovercards in general are probably due for an update and I wasn't quite sure what to do about it.

This revision was automatically updated to reflect the committed changes.