Paths

Table of Contentst

Fix a bad parameter read in hovercard
ClosedPublic
Actions

Authored by epriestley on Feb 18 2017, 12:39 AM.

Tags

None

Referenced Files

	F18807274: D17383.diff
	Sun, Oct 19, 12:16 AM

	F18783584: D17383.id41795.diff
	Mon, Oct 13, 8:16 AM

	F18783311: D17383.id41795.diff
	Mon, Oct 13, 5:55 AM

	F18756133: D17383.id.diff
	Sun, Oct 5, 9:28 AM

	F18745341: D17383.diff
	Fri, Oct 3, 6:16 AM

	F18733483: D17383.diff
	Tue, Sep 30, 10:35 PM

	F18566078: D17383.id.diff
	Sep 9 2025, 2:17 PM

	F18500615: D17383.diff
	Sep 4 2025, 9:12 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPa439ea7190fb: Fix a bad parameter read in hovercard

Summary

I broke this at the last second in D17374. getStrList() doesn't read arrays. It probably should (more modern analogs do) but don't rock the boat in the leadup to the release cut.

Test Plan

Hovered over a thing, saw a hovercard and no getStrList() error in my logs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 18 2017, 12:39 AM

epriestley mentioned this in Z1336: General Chat.Feb 18 2017, 12:39 AM

Harbormaster completed remote builds in B15688: Diff 41794.Feb 18 2017, 12:40 AM

chad accepted this revision.Feb 18 2017, 12:41 AM

This revision is now accepted and ready to land.Feb 18 2017, 12:41 AM

Closed by commit rPa439ea7190fb: Fix a bad parameter read in hovercard (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2017, 12:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorSearchHovercardController.php

2 lines

Diff 41795

View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Fix a bad parameter read in hovercardClosedPublicActions