Page MenuHomePhabricator

Fix a bad parameter read in hovercard
ClosedPublic

Authored by epriestley on Feb 18 2017, 12:39 AM.
Tags
None
Referenced Files
F15441525: D17383.id41794.diff
Wed, Mar 26, 6:37 PM
F15428533: D17383.id41794.diff
Sun, Mar 23, 9:00 PM
F15423537: D17383.id41794.diff
Sat, Mar 22, 3:51 PM
F15422698: D17383.id41795.diff
Sat, Mar 22, 10:15 AM
F15420349: D17383.id.diff
Fri, Mar 21, 1:16 PM
F15417773: D17383.diff
Thu, Mar 20, 6:22 PM
F15411539: D17383.id41794.diff
Wed, Mar 19, 9:26 AM
F15411538: D17383.id.diff
Wed, Mar 19, 9:26 AM
Subscribers
None

Details

Summary

I broke this at the last second in D17374. getStrList() doesn't read arrays. It probably should (more modern analogs do) but don't rock the boat in the leadup to the release cut.

Test Plan

Hovered over a thing, saw a hovercard and no getStrList() error in my logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable