Page MenuHomePhabricator
Differential D17341

Reduce application search engine results list for Dashboards
ClosedPublic
Actions

Authored by chad on Feb 12 2017, 6:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 10:57 PM
Unknown Object (File)
Mon, Dec 9, 4:22 AM
Unknown Object (File)
Nov 26 2024, 12:58 PM
Unknown Object (File)
Oct 24 2024, 3:56 AM
Unknown Object (File)
Oct 17 2024, 6:10 AM
Unknown Object (File)
Oct 14 2024, 5:11 PM
Unknown Object (File)
Oct 12 2024, 9:05 AM
Unknown Object (File)
Oct 12 2024, 8:59 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10390: Dashboards v2 (UX)
Commits
rPbf44210dc8f1: Reduce application search engine results list for Dashboards
Summary

Ref T10390. Simplifies dropdown by rolling out canUseInPanel in useless panels

Test Plan

Add a query panel, see less options.

Diff Detail

Repository
rP Phabricator
Branch
search-engine-panel-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15598
Build 20768: Run Core Tests
Build 20592: Run Core Tests
Build 20584: Run Core Tests
Build 20583: arc lint + arc unit

Event Timeline

chad created this revision.Feb 12 2017, 6:11 AM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 12 2017, 6:11 AM
Harbormaster completed remote builds in B15598: Diff 41701.Feb 12 2017, 6:12 AM
chad edited the test plan for this revision. (Show Details)Feb 12 2017, 6:13 AM
epriestley commandeered this revision.Feb 13 2017, 2:31 PM
epriestley edited reviewers, added: chad; removed: epriestley.
epriestley edited edge metadata.

Generally seems sane, I'll write some javascript. 😿

Harbormaster completed remote builds in B15598: Diff 41701.Feb 13 2017, 2:32 PM
chad edited edge metadata.Feb 13 2017, 2:39 PM

It's probably possible to build this into one mega-typeahead too. I just was unsure how that would feel.

chad commandeered this revision.Feb 22 2017, 1:39 AM
chad removed a reviewer: chad.

I think I'm just going to build this into a single typeahead and remove the javascript. That should make tab panel creation simple also.

Harbormaster completed remote builds in B15598: Diff 41701.Feb 22 2017, 1:40 AM
chad retitled this revision from Build a Typeahead for panel-ready application search engines to Reduce application search engine results list for Dashboards.Feb 22 2017, 5:19 PM
chad edited the summary of this revision. (Show Details)
chad edited the test plan for this revision. (Show Details)
chad updated this revision to Diff 41824.Feb 22 2017, 5:27 PM
  • filter out a few more useless ones
chad added a comment.Feb 22 2017, 5:28 PM

I reduced this diff down to just canUseInPanelContext changes -- along with better descriptions.

Harbormaster completed remote builds in B15721: Diff 41824.Feb 22 2017, 5:28 PM
epriestley accepted this revision.Feb 22 2017, 8:23 PM
This revision is now accepted and ready to land.Feb 22 2017, 8:23 PM
Closed by commit rPbf44210dc8f1: Reduce application search engine results list for Dashboards (authored by chad, committed by chad). · Explain WhyFeb 22 2017, 8:42 PM
This revision was automatically updated to reflect the committed changes.
ivo mentioned this in T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.Feb 27 2017, 6:05 PM

Revision Contents
Changeset List

Diff 41701

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php

Loading...
View Options

src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php

Loading...
View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

Loading...
View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Loading...
View Options

src/applications/dashboard/customfield/PhabricatorDashboardPanelSearchApplicationCustomField.php

Loading...
View Options

src/applications/dashboard/typeahead/PhabricatorDashboardPanelQueryDatasource.php

Loading...
View Options

src/applications/diviner/query/DivinerAtomSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptSearchEngine.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

Loading...
View Options

src/applications/phrequent/query/PhrequentSearchEngine.php

Loading...
View Options

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectColumnSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephBranchSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephProductSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestSearchEngine.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php

Loading...
Phabricator · Built by Phacility