Paths

Table of Contentst

Differential D17339

Add a Phurl Typeahead
ClosedPublic
Actions

Authored by chad on Feb 11 2017, 10:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 5, 2:03 AM

	Unknown Object (File)
	Wed, Dec 4, 7:07 PM

	Unknown Object (File)
	Wed, Dec 4, 8:26 AM

	Unknown Object (File)
	Tue, Nov 19, 11:05 AM

	Unknown Object (File)
	Thu, Nov 14, 1:57 AM

	Unknown Object (File)
	Thu, Nov 14, 1:29 AM

	Unknown Object (File)
	Wed, Nov 13, 11:06 PM

	Unknown Object (File)
	Nov 11 2024, 6:15 AM

Subscribers

Details

Reviewers

Commits

rP8b2880cfb749: Add a Phurl Typeahead

Summary

Adds a basic typeahead for Phurl Objects.

Test Plan

http://local.phacility.com/typeahead/browse/PhabricatorPhurlURLDatasource/

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 11 2017, 10:02 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 11 2017, 10:02 PM

Harbormaster completed remote builds in B15595: Diff 41698.Feb 11 2017, 10:03 PM

If you name a URL "Apple" but give it the alias "zebra" (so you reference it with ((zebra))) I think you should be able to find it by typing zebra. Currently, I believe it won't. You should be able to do this like this:

Make setName() (which is what it matches when typed) be "{$name}\n{$alias}".
Make setDisplayName() (which is what is shown to the user) be just the name.

This revision is now accepted and ready to land.Feb 11 2017, 10:29 PM

Closed by commit rP8b2880cfb749: Add a Phurl Typeahead (authored by chad, committed by chad). · Explain WhyFeb 11 2017, 11:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

phurl/

typeahead/

PhabricatorPhurlURLDatasource.php

35 lines

Diff 41699

src/__phutil_library_map__.php

Loading...

src/applications/phurl/typeahead/PhabricatorPhurlURLDatasource.php

Loading...