Adds a basic typeahead for Phurl Objects.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phurl-typeahead (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15595 Build 20579: Run Core Tests Build 20578: arc lint + arc unit
Event Timeline
Comment Actions
If you name a URL "Apple" but give it the alias "zebra" (so you reference it with ((zebra))) I think you should be able to find it by typing zebra. Currently, I believe it won't. You should be able to do this like this:
- Make setName() (which is what it matches when typed) be "{$name}\n{$alias}".
- Make setDisplayName() (which is what is shown to the user) be just the name.