Add a Phurl Typeahead
ClosedPublic
Actions

Authored by chad on Feb 11 2017, 10:02 PM.

Tags

None

Referenced Files

	F19654044: D17339.id.diff
	Fri, Feb 6, 3:18 PM

	F19654043: D17339.id.diff
	Fri, Feb 6, 3:18 PM

	F19503360: D17339.diff
	Jan 8 2026, 11:16 PM

	F18977168: D17339.diff
	Nov 16 2025, 5:11 PM

	F18789860: D17339.id41698.diff
	Oct 15 2025, 11:25 AM

	F18782919: D17339.diff
	Oct 13 2025, 2:59 AM

	F18770265: D17339.id.diff
	Oct 8 2025, 11:39 AM

	F18620622: D17339.id.diff
	Sep 15 2025, 5:46 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP8b2880cfb749: Add a Phurl Typeahead

Summary

Adds a basic typeahead for Phurl Objects.

Test Plan

http://local.phacility.com/typeahead/browse/PhabricatorPhurlURLDatasource/

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Feb 11 2017, 10:02 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 11 2017, 10:02 PM

Harbormaster completed remote builds in B15595: Diff 41698.Feb 11 2017, 10:03 PM

If you name a URL "Apple" but give it the alias "zebra" (so you reference it with ((zebra))) I think you should be able to find it by typing zebra. Currently, I believe it won't. You should be able to do this like this:

Make setName() (which is what it matches when typed) be "{$name}\n{$alias}".
Make setDisplayName() (which is what is shown to the user) be just the name.

This revision is now accepted and ready to land.Feb 11 2017, 10:29 PM

Closed by commit rP8b2880cfb749: Add a Phurl Typeahead (authored by chad, committed by chad). · Explain WhyFeb 11 2017, 11:31 PM

This revision was automatically updated to reflect the committed changes.