Differential D17334

Make the Phortune Subscription view show "Deleted Payment Method" for deleted payment methods
ClosedPublic
Actions

Authored by epriestley on Feb 10 2017, 4:50 PM.

Details

Reviewers

chad

Maniphest Tasks

T12224: Phortune "Autopay" on View controller does not respect disabled payment methods

Commits

rP29dc9e9ae1d3: Make the Phortune Subscription view show "Deleted Payment Method" for deleted…

Summary

Fixes T12224. This brings "Autopay" on the View controller into line with how it works on the Edit controller.

Test Plan

Viewed subscriptions with no autopay, valid autopay, and deleted autopay.

Screen Shot 2017-02-10 at 8.48.22 AM.png (188×415 px, 16 KB)

Diff Detail

Repository

rP Phabricator

Branch

phortune1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15586
Build 20565: Run Core Tests
Build 20564: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 10 2017, 4:50 PM

Harbormaster completed remote builds in B15586: Diff 41689.Feb 10 2017, 4:51 PM

chad accepted this revision.Feb 10 2017, 4:55 PM

This revision is now accepted and ready to land.Feb 10 2017, 4:55 PM

Closed by commit rP29dc9e9ae1d3: Make the Phortune Subscription view show "Deleted Payment Method" for deleted… (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2017, 12:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

controller/

PhortuneSubscriptionViewController.php

19 lines

Diff 41689

View Options

src/applications/phortune/controller/PhortuneSubscriptionViewController.php

Make the Phortune Subscription view show "Deleted Payment Method" for deleted payment methodsClosedPublicActions