Page MenuHomePhabricator
Differential D17330

Don't stem "words" with a "." or "_" in them
ClosedPublic
Actions

Authored by epriestley on Feb 9 2017, 7:27 PM.
Tags
None
Referenced Files
F14832577: D17330.id.diff
Thu, Jan 30, 5:39 AM
Unknown Object (File)
Tue, Jan 28, 2:13 AM
Unknown Object (File)
Tue, Jan 28, 2:13 AM
Unknown Object (File)
Tue, Jan 28, 2:13 AM
Unknown Object (File)
Sat, Jan 25, 2:26 PM
Unknown Object (File)
Tue, Jan 21, 8:20 PM
Unknown Object (File)
Tue, Jan 21, 9:20 AM
Unknown Object (File)
Fri, Jan 3, 2:43 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12106: task search not finding task with full word match
Commits
rPHU58fb3b94464e: (stable) Promote 2017 Week 6
rPHU82f71f62129b: Don't stem "words" with a "." or "_" in them
Summary

Fixes T12106. It is correct for us to stem "oddly-proportioned", but not "oddlyproportioned.com" or "maniphest.levelup" or "ad_hoc_token_thing".

Test Plan
  • Added a bunch of test coverage.
  • Created a task named "apples.bananas ducks_quacks". Found it by searching for "apples.bananas" and "ducks_quacks".

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
search/
12 lines
__tests__/
12 lines

Diff 41680

View Options

src/search/PhutilSearchStemmer.php

Loading...
View Options

src/search/__tests__/PhutilSearchStemmerTestCase.php

Loading...
Phabricator · Built by Phacility