Differential D17311

Limit damage caused by bad panels on dashboards you can manage
ClosedPublic
Actions

Authored by epriestley on Feb 4 2017, 2:33 AM.

Details

Reviewers

chad

Maniphest Tasks

T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR

Commits

rP9c62a10989e0: Limit damage caused by bad panels on dashboards you can manage

Summary

Fixes T12203. If you tried to manage a dashboard which had a panel you can't see, we'd try to render bogus actions for it and fatal.

Instead, for the moment, survive. Presumably we'll ship a real fix for this in the next release or so, and tackle T10612 / T10145, which I think are closely related.

Test Plan

Screen Shot 2017-02-03 at 6.31.21 PM.png (959×1 px, 160 KB)

Diff Detail

Repository

rP Phabricator

Branch

dash4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15531
Build 20481: Run Core Tests
Build 20480: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 4 2017, 2:33 AM

Harbormaster completed remote builds in B15531: Diff 41634.Feb 4 2017, 2:34 AM

chad accepted this revision.Feb 4 2017, 2:34 AM

This revision is now accepted and ready to land.Feb 4 2017, 2:34 AM

epriestley mentioned this in T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.Feb 4 2017, 2:34 AM

Closed by commit rP9c62a10989e0: Limit damage caused by bad panels on dashboards you can manage (authored by epriestley, committed by epriestley). · Explain WhyFeb 4 2017, 2:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

engine/

PhabricatorDashboardPanelRenderingEngine.php

4 lines

Diff 41634

View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Limit damage caused by bad panels on dashboards you can manageClosedPublicActions