Page MenuHomePhabricator

When a viewer can't see some of a dashboard's panels, only hide those panels
ClosedPublic

Authored by epriestley on Feb 3 2017, 5:58 PM.
Tags
None
Referenced Files
F15498522: D17308.diff
Sun, Apr 13, 1:09 PM
F15459265: D17308.id41626.diff
Mon, Mar 31, 11:30 AM
F15459023: D17308.id.diff
Mon, Mar 31, 9:11 AM
F15458949: D17308.diff
Mon, Mar 31, 8:33 AM
F15455921: D17308.id41626.diff
Sun, Mar 30, 5:43 AM
F15439156: D17308.id41625.diff
Wed, Mar 26, 6:03 AM
F15436205: D17308.id.diff
Tue, Mar 25, 12:34 PM
F15429860: D17308.diff
Mon, Mar 24, 4:40 AM
Subscribers
None

Details

Summary

Ref T12174. Ref T8033. Currently, if you can't see one panel on a dashboard, you can't see the dashboard at all. This is confusing and hard to debug.

Improve this behavior at least slightly: render the dashboard, with a big "you can't see this" panel in place of any panels you can't see. This should at least make the behavior obvious, even if it isn't the best or most comprehensive way we can handle it in all cases.

Test Plan

Screen Shot 2017-02-03 at 9.53.58 AM.png (935×1 px, 130 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable