Fix operator error in Pholio with PHP 7.1
ClosedPublic
Actions

Authored by chad on Jan 28 2017, 4:47 AM.

Tags

None

Referenced Files

	F15625866: D17260.diff
	Sun, May 18, 11:38 AM

	Unknown Object (File)
	Wed, May 7, 7:44 PM

	Unknown Object (File)
	Tue, May 6, 8:42 PM

	Unknown Object (File)
	Mon, Apr 21, 8:37 PM

	Unknown Object (File)
	Apr 18 2025, 2:13 PM

	Unknown Object (File)
	Apr 17 2025, 7:54 PM

	Unknown Object (File)
	Apr 11 2025, 11:53 AM

	Unknown Object (File)
	Apr 9 2025, 2:20 PM

View All Files

Subscribers

acs-ferreira

Korvin

Details

Reviewers

epriestley
acs-ferreira
Mnkras

Maniphest Tasks

T12166: EXCEPTION: (Error) [] operator not supported for strings

Commits

rP7a947947a39b: Fix operator error in Pholio with PHP 7.1

Summary

Fixes T12166. We don't actually need this variable, so removing it.

Test Plan

Upload a new mock, edit a mock, view list of mocks.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Jan 28 2017, 4:47 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 28 2017, 4:47 AM

Harbormaster completed remote builds in B15401: Diff 41518.Jan 28 2017, 4:48 AM

Mnkras accepted this revision.Jan 28 2017, 4:50 AM

This revision is now accepted and ready to land.Jan 28 2017, 4:50 AM

Confirm that it fixes T12166

epriestley accepted this revision.Jan 28 2017, 6:52 AM

Closed by commit rP7a947947a39b: Fix operator error in Pholio with PHP 7.1 (authored by chad, committed by chad). · Explain WhyJan 28 2017, 3:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

view/

PholioMockImagesView.php

5 lines

Diff 41520

View Options

src/applications/pholio/view/PholioMockImagesView.php

Fix operator error in Pholio with PHP 7.1ClosedPublicActions