Page MenuHomePhabricator

Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI
ClosedPublic

Authored by epriestley on Jan 25 2017, 7:25 PM.
Tags
None
Referenced Files
F18822794: D17248.diff
Thu, Oct 23, 8:30 AM
F18822793: D17248.diff
Thu, Oct 23, 8:30 AM
F18806441: D17248.id41484.diff
Sat, Oct 18, 7:31 PM
F18769419: D17248.id.diff
Wed, Oct 8, 7:34 AM
F18761689: D17248.id.diff
Mon, Oct 6, 3:44 PM
F18758249: D17248.diff
Sun, Oct 5, 9:21 PM
F18592011: D17248.diff
Sep 12 2025, 11:01 AM
F17940514: D17248.id41490.diff
Jul 31 2025, 4:30 AM
Subscribers
None

Details

Summary

Ref T11114. Converting to EditEngine caused us to stop running this validation, since these fields no longer subclass this parent. Restore the validation.

Also, make sure we check the first line of the value, too. After the change to make "Tests: xyz" a valid title, you could write silly summaries / test plans and escape the check if the first line was bogus.

Test Plan

Screen Shot 2017-01-25 at 11.22.29 AM.png (1×1 px, 174 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable