Page MenuHomePhabricator
Differential D17214

Make documentation items in user menu update as you navigate in Quicksand
ClosedPublic
Actions

Authored by epriestley on Jan 17 2017, 10:01 PM.
Tags
None
Referenced Files
F14332108: D17214.diff
Wed, Dec 18, 4:14 PM
Unknown Object (File)
Mon, Dec 9, 7:03 AM
Unknown Object (File)
Sun, Dec 8, 4:17 AM
Unknown Object (File)
Thu, Dec 5, 10:24 PM
Unknown Object (File)
Wed, Dec 4, 5:58 PM
Unknown Object (File)
Wed, Dec 4, 2:21 AM
Unknown Object (File)
Sun, Dec 1, 2:34 AM
Unknown Object (File)
Thu, Nov 28, 8:27 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5867: Move Quick Create to MenuItemEngine
Commits
rPa886969c480f: Make documentation items in user menu update as you navigate in Quicksand
Summary

Ref T5867. I sure love Javascript.

Test Plan

Navigated between Home, Diffusion and Differential, opening the user profile menu. Saw appropraite help items.

Diff Detail

Repository
rP Phabricator
Branch
menu2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15295
Build 20128: Run Core Tests
Build 20127: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 17 2017, 10:01 PM
epriestley retitled this revision from Make documentation in user menu update as you navigate to Make documentation items in user menu update as you navigate in Quicksand.Jan 17 2017, 10:02 PM
Harbormaster completed remote builds in B15295: Diff 41406.Jan 17 2017, 10:02 PM
epriestley updated this revision to Diff 41407.Jan 17 2017, 10:04 PM
  • Keep the bit for updating notification/conpherence counts.
  • Toss the bit for hiding and showing the help menu.
Harbormaster completed remote builds in B15296: Diff 41407.Jan 17 2017, 10:05 PM
chad edited edge metadata.Jan 17 2017, 10:40 PM

Sorry you had to write so much for this...

chad accepted this revision.Jan 17 2017, 10:40 PM
This revision is now accepted and ready to land.Jan 17 2017, 10:40 PM
Closed by commit rPa886969c480f: Make documentation items in user menu update as you navigate in Quicksand (authored by epriestley, committed by epriestley). · Explain WhyJan 17 2017, 11:55 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D17210: Hide dropdown menus when users click workflow items.Jan 18 2017, 7:04 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
33 lines
src/
applications/
base/
17 lines
home/
application/
41 lines
view/
layout/
2 lines
page/
29 lines
phui/
12 lines
webroot/
rsrc/
js/
application/
aphlict/
30 lines
core/
57 lines

Diff 41406

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/home/application/PhabricatorHomeApplication.php

Loading...
View Options

src/view/layout/PhabricatorActionView.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...
View Options

webroot/rsrc/js/core/behavior-user-menu.js

Loading...
Phabricator · Built by Phacility