Page MenuHomePhabricator
Differential D17204

Get "Create Revision" out of Quick Create menu for now
ClosedPublic
Actions

Authored by epriestley on Jan 13 2017, 2:21 PM.
Tags
None
Referenced Files
F17936389: D17204.id.diff
Jul 31 2025, 12:12 AM
F17817240: D17204.id.diff
Jul 25 2025, 11:23 PM
F17804504: D17204.id41365.diff
Jul 25 2025, 11:28 AM
F17740925: D17204.id41365.diff
Jul 21 2025, 7:42 AM
F17740924: D17204.id.diff
Jul 21 2025, 7:42 AM
F17740566: D17204.id41367.diff
Jul 21 2025, 6:30 AM
F17735563: D17204.diff
Jul 20 2025, 2:37 PM
Unknown Object (File)
Jul 5 2025, 8:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12098: Create Revision from FavoritesMenuItem doesn't work
Commits
rPe684794bf33d: Get "Create Revision" out of Quick Create menu for now
Summary

Ref T12098.

We have two methods (supportsEditEngineConfiguration() and isEngineConfigurable()) which sort of do the same thing and probably should be merged.

For now, just swap which one we override to get "Create Revision" out of the Quick Create menu.

Test Plan

No more "Create Revision" in Quick Create menu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 13 2017, 2:21 PM
Harbormaster completed remote builds in B15253: Diff 41365.Jan 13 2017, 2:23 PM
chad accepted this revision.Jan 13 2017, 2:51 PM
This revision is now accepted and ready to land.Jan 13 2017, 2:51 PM
Closed by commit rPe684794bf33d: Get "Create Revision" out of Quick Create menu for now (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2017, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
2 lines

Diff 41367

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
Phabricator · Built by Phacility