Differential D17187

Prevent users from resigning from audits they've already resigned from
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 11:27 PM.

Details

Reviewers

chad

Maniphest Tasks

T10978: Modernize Audit

Commits

rPb941331bdfe6: Prevent users from resigning from audits they've already resigned from

Summary

Ref T10978. Since "Resigned" is a status in Audit, you could repeatedly resign. This is confusing; prevent it.

Test Plan

Tried to resign twice; was only allowed to resign once.

Diff Detail

Repository

rP Phabricator

Branch

commit12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15217
Build 20001: Run Core Tests
Build 20000: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 11 2017, 11:27 PM

Harbormaster completed remote builds in B15217: Diff 41330.Jan 11 2017, 11:28 PM

chad accepted this revision.Jan 11 2017, 11:42 PM

This revision is now accepted and ready to land.Jan 11 2017, 11:42 PM

Closed by commit rPb941331bdfe6: Prevent users from resigning from audits they've already resigned from (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2017, 12:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

xaction/

DiffusionCommitAuditTransaction.php

17 lines

DiffusionCommitResignTransaction.php

6 lines

Diff 41330

View Options

src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php