Page MenuHomePhabricator

Re-darken full width diff colors

Authored by chad on Jan 10 2017, 9:14 PM.



Ref T12089. This reverts back to using "bright" colors for full width changes in green and red.

Test Plan

Review diffs, see full width colors.

pasted_file (1×3 px, 995 KB)

Diff Detail

rP Phabricator
diff-colors (branched from master)
Lint Passed
No Test Coverage
Build Status
Buildable 15184
Build 19950: Run Core Tests
Build 19949: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 10 2017, 9:20 PM

this green has more contrast than the previous "bright" green, just FYI, which is why I made this change.

This revision was automatically updated to reflect the committed changes.

If this color scheme isn't good for red-green colorblind users we can introduce a setting, but this was definitely noticeably worse for me too (I just couldn't put my finger on why).