Paths

Table of Contentst

Differential D17153

Return milestone information in project.search
ClosedPublic
Actions

Authored by epriestley on Jan 8 2017, 7:32 PM.

Tags

None

Referenced Files

	F13049931: D17153.id41257.diff
	Fri, Apr 19, 2:31 AM

	F13049930: D17153.id41251.diff
	Fri, Apr 19, 2:31 AM

	F13049929: D17153.id.diff
	Fri, Apr 19, 2:31 AM

	Unknown Object (File)
	Wed, Apr 17, 3:18 PM

	Unknown Object (File)
	Thu, Apr 11, 3:52 AM

	Unknown Object (File)
	Sun, Apr 7, 10:55 AM

	Unknown Object (File)
	Sat, Apr 6, 4:30 PM

	Unknown Object (File)
	Sat, Apr 6, 1:08 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12074: conduit API extensions for subprojects and milestones.

Commits

rPe03103f34920: Return milestone information in project.search

Summary

project.search now returns milestones by default.
A new constraint, isMilestone, allows filtering to milestones, non-milestones, or both (API and web UI).
project.search now returns a milestone number for milestones, or null for non-milestones.

NOTE: Existing custom saved queries in projects which previously did not return milestones now will. I expect this to have little-to-no impact on users, and these queries are easy to correct, but I'll note this in changelogs.

Test Plan

Ran various queries with project.search and in the web UI, searching for milestones, non-milestones, and both.
Web UI default behavior (no milestones) is unchanged, but you can now get milestones if you want them.
Queried a milestone by ID/PHID via API.

Diff Detail

Repository

Branch

project1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15139
Build 19880: Run Core Tests
Build 19879: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 8 2017, 7:32 PM

Harbormaster completed remote builds in B15139: Diff 41251.Jan 8 2017, 7:33 PM

chad accepted this revision.Jan 8 2017, 7:51 PM

This revision is now accepted and ready to land.Jan 8 2017, 7:51 PM

Closed by commit rPe03103f34920: Return milestone information in project.search (authored by epriestley, committed by epriestley). · Explain WhyJan 8 2017, 9:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectSearchEngine.php

21 lines

storage/

PhabricatorProject.php

11 lines

Diff 41251

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...